Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47027 )
Change subject: soc/intel/broadwell/pch/sata.c: Use common ABAR helpers
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47027/2/src/soc/intel/broadwell/pch...
File src/soc/intel/broadwell/pch/sata.c:
https://review.coreboot.org/c/coreboot/+/47027/2/src/soc/intel/broadwell/pch...
PS2, Line 85: Should be configurable
so, why isn't it configurable?
No one seems to need eSATA support in coreboot. Hotplug works already.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2316794628be1ebc524aaa6a460ba6770b700a56
Gerrit-Change-Number: 47027
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 12:19:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment