Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82769?usp=email )
Change subject: nb/via/cx700: Implement FSB tuning ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82769/comment/d7bed464_b9c3dc32?usp... : PS2, Line 17: seems unclear if it was put there intentionally.
If this soft reset doesn't clear the FSB settings, I imagine it's to help commit the settings. […]
I should probably check what sticks. I know at least the reset bit sticks because that's what made the original code work: it only resets when changing it from 0 to 1. The original code just went through the whole list again, second time without reset. It could still make sense if it was on purpose, it's actually quite elegant if one wanted to compact the code as much as possible.