Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Subrata Banik, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56651 )
Change subject: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This is a finding by us and we had initiated a discussion to capture the details at validation side, […]
Subrata there are two changes that happen under X86_AMD_INIT_SIPI/X86_INIT_SIPI:
1. Remove the 10msec delay after sending INIT
2. Second SIPI is skipped
Both of these are not documented anywhere. When you say that "this is a finding by us" --> Finding based on? And has this been confirmed with the h/w architecture team. If so, then it should be updated as an addendum to the MP spec or added to BWG to make it clear what platforms really support this.
Also, I see the linux kernel still following the same specification: https://elixir.bootlin.com/linux/latest/source/arch/x86/kernel/smpboot.c#L79...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62
Gerrit-Change-Number: 56651
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 28 Jul 2021 19:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment