Attention is currently required from: Tarun Tuli, Sridhar Siricilla.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 )
Change subject: soc/intel/: Store ISH firmware version into cbmem table ......................................................................
Patch Set 15:
(5 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74208/comment/e5fe2910_86d88490 PS14, Line 1278: FSP-M
memory?
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/26bab3e2_cfdd16a2 PS14, Line 1279: CSE DRAM
DRAM. […]
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/96b52d2b_bf4d6965 PS14, Line 1282: store_ish_version
Can we move this definition to new file?
I believe the cse.c file is a good place to put the new API for the ISH because other relevant APIs are already there.
https://review.coreboot.org/c/coreboot/+/74208/comment/e0beef46_651cc5c3 PS14, Line 1305: version->ish_partition_info.prev_cse_fw_version.major : = version->cur_cse_fw_version.major; : version->ish_partition_info.prev_cse_fw_version.minor : = version->cur_cse_fw_version.minor; : version->ish_partition_info.prev_cse_fw_version.hotfix : = version->cur_cse_fw_version.hotfix; : version->ish_partition_info.prev_cse_fw_version.build : = version->cur_cse_fw_version.build; :
can you define generic function for copying the version from src to destination? […]
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/d3c6a203_432b6da1 PS14, Line 1315: version->ish_partition_info.cur_ish_fw_version.major : = resp.manifest_data.version.major; : version->ish_partition_info.cur_ish_fw_version.minor : = resp.manifest_data.version.minor; : version->ish_partition_info.cur_ish_fw_version.hotfix : = resp.manifest_data.version.hotfix; : version->ish_partition_info.cur_ish_fw_version.build : = resp.manifest_data.version.build;
You may use generic version copy function (cse_copy_fw_version) for this as described above?
Ack