[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8192: add spmfw loader

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )

Change subject: mediatek/mt8192: add spmfw loader
......................................................................

Patch Set 15:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... 
File src/soc/mediatek/mt8192/spm.c:

https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... 
PS15, Line 947: 		write32(&mtk_spm->pcm_con1, read32(&mtk_spm->pcm_con1) |
              : 			SPM_REGWR_CFG_KEY | RG_IM_SLAVE_LSB);
How does this path work? How do you guarantee that the SPM firmware is loaded again if it changed?

https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... 
PS15, Line 951: 	/* kick IM to fetch (only toggle IM_KICK) */
The code below does not seem to match what this comment says.