Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usbhub.c:
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 181: > This should either be >= or better to add a helper: is_usb_hub_enhanced_ss() which checks if speed is SUPER_SPEED or SUPER_SPEED_PLUS and returns true.
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 190: > Same comment as above.
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/xhci_devconf.c:
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 270: > same comment as other file.