Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43672 )
Change subject: smbios: Add Type19
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43672/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43672/1/src/arch/x86/smbios.c@1098
PS1, Line 1098:
You need to initialize starting_address and ending_address to 0xffffffff so that the extended values […]
We can also make use of these fields as they are in kilobytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43672
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idee8b8cd0b155e14d62d4c12893ff01878ef3f1c
Gerrit-Change-Number: 43672
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Jul 2020 15:20:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment