Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Subrata Banik, Dinesh Gehlot, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74382 )
Change subject: soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74382/comment/7ce8da1f_ae35d5cc PS1, Line 9: The patch moves API that gets the CSE FW partition information into : CSE Lite specific file aka cse_lite.c because the consumer of this API : is the cse_lite specific ChromeOS devices hence, it's meaningful to : move the cse lite specific implementation inside cse_lite.c file.
cse.c represents library, provides API. […] cse.c can't be a library because it has other pci ops entries. Today the R&R of cse. c and cse_lite.c are not very clear.
Portion of code sets up the communication with CSE while most of the code represents CSE command handlers and helper other functions which can be consumed by all CSE SKUs. The CSE.C file size increased significantly, it's better CSE command handlers/helper functions need to be maintained in a separate file while leaving CSE driver code into this file.
Coming to the reason why i moved this API into cse_lite.c. seems like this whole patchsets and incremental patch train is very specific to CSE lite implementation and chromeos use case, where we would like to store the cse rw version after CSE sync being done (either in romstage or ramstage)
You can still make GET IMAGE FW Version command handler public so that you can refer it from cse_lite.c.
But, you may go ahead with your current implementation. Anyways cse code needs to be refactored to prepare a pristine cse lib.