[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds

[Subrata Banik (Code Review)]

Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier.

Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )

Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/dedede/Kconfig:

https://review.coreboot.org/c/coreboot/+/84359/comment/1c2a117c_d08bc635?usp... :
PS1, Line 39: 	select SOC_INTEL_CRASHLOG
> I also don't know why we'd want to move it to the SoC vs the mainboard

ideally MAINBOARD_HAS_CHROMEOS and CHROMEOS seem to be the same thing. I get how you plan to work around it by moving SOC_INTEL_CRASHLOG under the CHROMEOS config, since we don't select CHROMEOS from the main board kconfig in upsream.

we select the below config from our .config.
```
# Chrome OS
CONFIG_CHROMEOS=y

```

Although I don't see any problem w/ CB:84365 cl but I felt this cl is a W/A to the problem that you faced while booting windows/linux on jsl Chromebook.