Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46030 )
Change subject: pci_device: Add a helper function for determining if PCI device is wake source
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46030/1/src/include/device/pci.h
File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/46030/1/src/include/device/pci.h@88
PS1, Line 88: void pci_dev_log_wake(const struct device *dev, uint8_t source_id, uint32_t instance);
Could split out a lower level utility function: pci_dev_is_wake_src. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46030
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06e9530b568543ab2f05a4f38dc5c3a527ff391e
Gerrit-Change-Number: 46030
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 06:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment