Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30895 )
Change subject: Documentation: Add Asus F2A85-M ......................................................................
Patch Set 3: Code-Review+1
(6 comments)
Very nice. Thank you for writing this. I have some more nitpicks. It’d be great if you fixed those.
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... File Documentation/mainboard/asus/f2a85-m.md:
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... PS3, Line 14: Both "Trinity" and "Richland" desktop processing units are working Add a period/dot at the end of the sentence?
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... PS3, Line 15: TeraScale 3 (VLIW4-based) A link to Wikipedia or some other page with details would be handy.
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... PS3, Line 25: GPU(APUs only) Space before the (?
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... PS3, Line 127: # dd if=/dev/mem of=vgabios.bin bs=1k count=64 skip=768 Just indent with four spaces to have it mark up as code?
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... PS3, Line 150: are also useless What does this mean? They do not work?
https://review.coreboot.org/#/c/30895/3/Documentation/mainboard/asus/f2a85-m... PS3, Line 180: PS/2 keyboard It says untested above.