Attention is currently required from: Subrata Banik, Dinesh Gehlot.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74255 )
Change subject: soc/intel/cmd/block/cse: Add config option for storing fw version info ......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/74255/comment/b5da5037_5fdef95b PS13, Line 48: config SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION : bool : default n : depends on DRIVERS_INTEL_ISH : help : This configuration option stores CSE FPT partitions' version in CBMEM memory. : This information can be used to identify the currently running firmware partition : version. Sorry, for bringing this up again. No idea, if it was answered in another change-set comment, but I think, it should be clear from the Kconfig description.
1. Why does this need to be configurable, and cannot be enable unconditionally? 2. Why does this information need to be stored in CBMEM? If the firmware is updated in coreboot, why can’t coreboot read the version information directly? Is it some boundaries between stages? I thought mainly CBMEM is used to pass information to later programs like payloads or the OS (CBMEM console).