Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: [RFC] device: Add method for configuring bus master based on config option ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42459/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42459/1//COMMIT_MSG@9 PS1, Line 9: coreboots
coreboot's
Done
https://review.coreboot.org/c/coreboot/+/42459/4/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/42459/4/src/device/pci_device.c@165... PS4, Line 1653: void pci_configure_bus_master(struct device *dev)
void pci_dev_enable_bus_master(const struct device *dev)
Done
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h@13... PS4, Line 131: void pci_configure_bus_master(struct device *dev);
I would rather use "configure". IMO this relates more to a config option. […]
Done