Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34617 )
Change subject: mb/google/nocturne: Add MKBP events to SCI mask
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34617/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34617/1//COMMIT_MSG@13
PS1, Line 13: By adding the MKBP event to the SCI mask,
Wouldn't this cause MKBP events coming in via two paths and cause problems with the tight timestamps?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfb6fc4d272ebb4ee82ab7b2d0d4f400cf8679cc
Gerrit-Change-Number: 34617
Gerrit-PatchSet: 1
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Jul 2019 18:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment