Attention is currently required from: Raul Rangel, Martin Roth, Karthik Ramasubramanian, EricR Lai.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51043 )
Change subject: mb/google/guybrush: Enable Chrome EC
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51043/comment/bc09e77e_2342a67a
PS4, Line 22: mainboard_ec_init
Do we need to configure the GPIOs before the EC? I'm not sure what the default state of the eSPI pin […]
eSPI GPIOs are configured in verstage in zork, I could add eSPI GPIO configuration to bootbock for now or wait until we have psp verstage ready.
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/51043/comment/d672d25b_2d3f7fe3
PS4, Line 26: SMI
Are we really using SMIs for this?
From what I can tell it is not important but all other boards define it this way. Happy to take it out if it is not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51043
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb
Gerrit-Change-Number: 51043
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 14:24:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment