[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp: Add Compaq Elite 8300 CMT port

[Riku Viitanen (Code Review)]

Attention is currently required from: Felix Singer, Nicholas Chin, Nico Huber, Paul Menzel.

Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79745?usp=email )

Change subject: mb/hp: Add Compaq Elite 8300 CMT port
......................................................................

Patch Set 18:

(14 comments)

Patchset:

PS18: 
will convert to variant next

File src/mainboard/hp/compaq_elite_8300_cmt/Kconfig:

https://review.coreboot.org/c/coreboot/+/79745/comment/80c69211_36a9f33a?usp... :
PS17, Line 1: if
>

Done

File src/mainboard/hp/compaq_elite_8300_cmt/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/79745/comment/9e6dab2c_7bc5f19f?usp... :
PS17, Line 1: co
>

Done

File src/mainboard/hp/compaq_elite_8300_cmt/acpi/ec.asl:

https://review.coreboot.org/c/coreboot/+/79745/comment/a6956532_74b38021?usp... :
PS17, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
>

Done

File src/mainboard/hp/compaq_elite_8300_cmt/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/79745/comment/582c6075_18e61260?usp... :
PS17, Line 4: 	register "gfx.use_spread_spectrum_clock" = "0"
            : 	register "gpu_dp_b_hotplug" = "0"
            : 	register "gpu_dp_c_hotplug" = "0"
            : 	r
> Remove, since initialized with 0.

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/390c2249_54b1fce9?usp... :
PS17, Line 13: 		device ref host_bridge on end # Host bridge Host bridge
             : 		device ref peg10 on end # PEG
             : 		device ref igd on end # iGPU
> Please remove superfluous comments duplicating the device names. More are below. […]

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/0b61e11e_84281b76?usp... :
PS17, Line 18: 			register "docking_supported" = "0"
             :
> Remove, initialized with 0. […]

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/f953431f_9fa5b642?usp... :
PS17, Line 21: 			register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
             :
> Remove, initialized with 0. […]

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/2cf7352a_a88d617d?usp... :
PS17, Line 49: 			device ref mei2 off  end
             : 			device ref me_ide_r off end
             : 			device ref me_kt off end
             :
> Remove, disabled by default. […]

Done

File src/mainboard/hp/compaq_elite_8300_cmt/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/79745/comment/094741a8_2b0ac028?usp... :
PS17, Line 11: 	0x20141018	/* OEM revision */
>

Done

File src/mainboard/hp/compaq_elite_8300_cmt/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/79745/comment/8eced96e_edf6a38a?usp... :
PS17, Line 10: 	AZALIA_PIN_CFG(0, 0x12, 0x411111f0),
>

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/0bf70770_68ad9d67?usp... :
PS17, Line 13: 	AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
             : 	A
>

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/321a7514_d8dde9ba?usp... :
PS17, Line 18: 	AZALIA_PIN_CFG(0, 0x1e, 0x411111f0),
>

Done

https://review.coreboot.org/c/coreboot/+/79745/comment/f6a8a7c6_8fe8c469?usp... :
PS17, Line 27: 	AZALIA_PIN_CFG(3, 0x07, 0x58560030),
             : 
             : };
> Remove blank line […]

Done