Attention is currently required from: Angel Pons, Paul Menzel, Pratikkumar V Prajapati.
Alexander Couzens has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/75214?usp=email )
Change subject: inteltool: improve support for Elkhart Lake
......................................................................
Patch Set 5:
(1 comment)
File util/inteltool/spi.c:
https://review.coreboot.org/c/coreboot/+/75214/comment/a5ec2a14_7e2a6441?usp... :
PS5, Line 450: !rcba_size
Isn't this check a bit redundant?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75214?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida852f3c991cdd036d9c282f9cabceb23c765e25
Gerrit-Change-Number: 75214
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 16:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com