Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42566 )
Change subject: util/amdfwtool: Add support for EFS SPI values for F17h and F15h ......................................................................
Patch Set 10:
I assume there is only NDA documentation for EFS?
In the case of a Micron part, will PSP send 0xb1/0xb5 commands to the SPI flash part such that QPR modes on both sides agree about the number of dummy cycles? Or is it necessary to use some proprieatary tool to configure non-volatile registers in the Micron part instead?
In case of a non-Micron part, what happens? One cannot change to QPR modes if power-on defaults about dummy-cycle counts disagree. I think it was a Winbond part that could not use 100MHz with 1-1-2 or 1-2-2 so there is additional dependencies.
I understand if you cannot publish relevant parts of existing BOMs, but documenting which SPI parts are expected to work with the PSP firmwares you release would have some value. And perhaps a general statement in the commit message that SPI parts are no longer as interchangeable as they used to be.