[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIF and PMIC driver support

[Hope Wang (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.

Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support
......................................................................

Patch Set 14:

(7 comments)

File src/soc/mediatek/mt8196/include/soc/pmif.h:

https://review.coreboot.org/c/coreboot/+/85126/comment/05612f2d_4b19ce36?usp... :
PS12, Line 142:
> Just one tab.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/910c8eef_0e9f4a3b?usp... :
PS12, Line 142: +
> Space around `+`

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/a8e60b8f_2bb7ca69?usp... :
PS12, Line 142: #define SPMI_SCL_M_PD_ADDR		(IOCFG_LM2_BASE+0x80)
              : #define SPMI_SDA_M_PD_ADDR		(IOCFG_LM2_BASE+0x80)
              : #define SPMI_SCL_P_PD_ADDR		(IOCFG_LM2_BASE+0x80)
              : #define SPMI_SDA_P_PD_ADDR		(IOCFG_LM2_BASE+0x80)
> Why do we need 4 macros, if their values are all the same?

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/92929032_6200c0c7?usp... :
PS12, Line 147: )
> remove

Done

File src/soc/mediatek/mt8196/pmif_clk.c:

https://review.coreboot.org/c/coreboot/+/85126/comment/d7292a7a_7476e36b?usp... :
PS6, Line 188: 	ret |=  pmif_check_vlpck_freq(PMIF_VLPCK_TARGET_FREQ_MHZ);
> extra space after =

Done

File src/soc/mediatek/mt8196/pmif_spmi.c:

https://review.coreboot.org/c/coreboot/+/85126/comment/4a13e57b_6152896e?usp... :
PS12, Line 164: IOCFG_LM2_BASE + 0x4
> Define macros for `IOCFG_LM2_BASE + 0x4` and `IOCFG_LM2_BASE + 0x8`, respecitvely, just like `SPMI_S […]

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/890f6cab_0dd7c793?usp... :
PS12, Line 221: (
> remove

Done