Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/...
PS4, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci,
: [PchSerialIoIndexI2C3] = PchSerialIoPci,
keep it not change
Sorry, I meant it's okay to set those as disabled.
https://review.coreboot.org/c/coreboot/+/36086/4/src/mainboard/google/hatch/...
PS4, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci,
keep it not change
Sorry, I meant it's okay to set those as disabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9
Gerrit-Change-Number: 36086
Gerrit-PatchSet: 5
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 15:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-MessageType: comment