[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions

[Cliff Huang (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Hannah Williams, Jamie Ryu, Subrata Banik.

Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )

Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................

Patch Set 3:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84104/comment/3247c0d3_d495dd79?usp... :
PS3, Line 10: ppe0
> gpe0

Done

File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/84104/comment/33f08d7a_9730eab1?usp... :
PS3, Line 367: pmc_clear_std_gpe_status
> I like this idea to use a single api to clear std gpe0 and gpe1.

Done

https://review.coreboot.org/c/coreboot/+/84104/comment/8770fb7f_a250e983?usp... :
PS3, Line 368: gpi
> pmc_clear_std_gpe1_status?

renamed to reset_std_gpe1_status() like the one for gpe0.

https://review.coreboot.org/c/coreboot/+/84104/comment/cea5eb50_12399ab3?usp... :
PS3, Line 393: void pmc_clear_std_gpe1_status
> Can this be instead pmc_clear_gpe1_status ? Unlike GPE0, you don't need the STD offset to be handled […]

Acknowledged