Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: src: Use standard <inttypes.h>
......................................................................
Patch Set 7:
I generally like the idea to keep our headers as close
to the standard as possible.
Regarding this change:
* inttypes.h like the stdint.h counterpart is arch specific. e.g. if `int64_t` is defined as `long long int` then u need `ll` prefix, if it is defined as `long int` you only need `l`.
* Adding all the standard types even if we don't use all of them increases the maintenance burden for naught. e.g. why add *int_fast*/*int_least* if nobody is ever going to use them?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3a300f9b1c38e4831b030ff8af3fed2fa60f14
Gerrit-Change-Number: 33823
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Jun 2019 07:06:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment