Attention is currently required from: Angel Pons, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58386 )
Change subject: cpu/x86/lapic: unconditionally use CPUID leaf 0xb if available
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58386/comment/b68c3f9c_dab0d036
PS1, Line 7: cpu/x86/lapic: Use CPUID leaf 0xb without X2APIC
+1
Done
Patchset:
PS2:
Kyösti wrote on the IRC channel: "hell had some failure with x2apic mode, not sure if this was related" so let's keep this as an unresolved comment. i don't think that this patch should cause any problems, but better double-check
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f1f46fe5091ebeab6dfb4c7e151150cf495d0cb
Gerrit-Change-Number: 58386
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 18 Dec 2021 13:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment