Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Subrata Banik, Sathya Prakash M R. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Fix Tmode setting for ADL P RVP ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56208/comment/14c801d4_a2d98829 PS1, Line 7: mb/intel/adlrvp: Fix Tmode setting for ADL P RVP Please be more specific and rephrase to something like:
Use HDA TMODE 8T to match spec
https://review.coreboot.org/c/coreboot/+/56208/comment/380c2e9e_f47b530f PS1, Line 8: Please describe the problem first:
HDMI/DP playback currently does not work. …
https://review.coreboot.org/c/coreboot/+/56208/comment/b34e1f3e_55004a27 PS1, Line 13: carry carried
https://review.coreboot.org/c/coreboot/+/56208/comment/55b60179_b20a6e4b PS1, Line 13: Earlier setting was with older FSP which was carry forwarded. What FSP version did you test with?
https://review.coreboot.org/c/coreboot/+/56208/comment/be8d07e4_b976c798 PS1, Line 16: HDMI /DP HDMI/DP
https://review.coreboot.org/c/coreboot/+/56208/comment/dc690aad_af303988 PS1, Line 17: Please add a fixes tag:
Fixes: …