26 Nov
2019
26 Nov
'19
2:12 p.m.
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_FAFT_KEY_OVERIDE setting ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36518/7/src/soc/qualcomm/common/qcl... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/7/src/soc/qualcomm/common/qcl... PS7, Line 162: if (!(gbb_is_flag_set(VB2_GBB_FLAG_FAFT_KEY_OVERIDE))) {
'OVERIDE' may be misspelled - perhaps 'OVERRIDE'?
This is how flag is spelled in vboot source code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36518
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63f35c94bc6c60934ace5fe0fd9176443059b354
Gerrit-Change-Number: 36518
Gerrit-PatchSet: 8
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 26 Nov 2019 22:12:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment