Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62791 )
Change subject: soc/mediatek: Add chip config for setting PCIe config
......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62791/comment/de6c25f8_a00f959b
PS2, Line 109: pcie_ctrl
I add an individual patch to replace this global variable: […]
Thanks. the pcidev_path_on_root approach is even better.
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62791/comment/136ba1ad_13edfa10
PS3, Line 168: ctrl
"conf" or something similar
https://review.coreboot.org/c/coreboot/+/62791/comment/fc96f856_1d600a94
PS3, Line 180: ctrl
Same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icff83f2a9f76862065987a74cfcc7e511be80a20
Gerrit-Change-Number: 62791
Gerrit-PatchSet: 3
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 06:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-MessageType: comment