[coreboot-gerrit] Change in ...coreboot[master]: device/root_device: Scan bridges on LPC bus too

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29474 )

Change subject: device/root_device: Scan bridges on LPC bus too
......................................................................

Patch Set 5: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/29474/5/src/device/root_device.c 
File src/device/root_device.c:

https://review.coreboot.org/#/c/29474/5/src/device/root_device.c@66 
PS5, Line 66: void scan_lpc_bus(struct device *bus)
Looks very much like scan_usb_bus() and root_dev_scan_bus().

https://review.coreboot.org/#/c/29474/5/src/device/root_device.c@105 
PS5, Line 105: 		link->secondary = ++bus_max;
This is weird, each path type (PCI/SMBus/LPC/xx) should have separate enumeration for the bus number.