Attention is currently required from: Ronak Kanabar.
Sean Rhodes has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/82780?usp=email )
Change subject: vc/intel/fsp: Update ADL N FSP headers from v3343.05 to v5021.00
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Okay, but shouldn't they be the stock ones then? And then Google has a "custom" directory or somet […]
Fair enough. The problem with the header Kconfig is the memory info hobs differ in the Intel downloads; there's a Kconfig tied to that but it seems to break other things so the only way is to smush the directories together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82780?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb4cc8f2f83d8f6e821894f0ec2e56262a25743c
Gerrit-Change-Number: 82780
Gerrit-PatchSet: 3
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Wed, 03 Jul 2024 13:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com