Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Poornima Tom.
Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83148?usp=email )
Change subject: mb/google/nissa/var/nivviks: Disable CNVi Bluetooth based on fw_config
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/fw_config.c:
https://review.coreboot.org/c/coreboot/+/83148/comment/e76b31d0_336ccc9b?usp... :
PS1, Line 120: }
shouldn't we also disable the cnvi wifi core too ?
ideally I would say, if !wifi_6 then make sure to disable both cnvi wifi and bt
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83148?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03fde02fa4b36f4e47d6f0e95675feddb3bee7cd
Gerrit-Change-Number: 83148
Gerrit-PatchSet: 1
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 21 Jun 2024 09:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No