Attention is currently required from: Jonathan Neuschäfer, Patrick Rudolph, Philipp Hug.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79951?usp=email )
Change subject: drivers/uart/sifive.c: Fix divisor calculation
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/uart/sifive.c:
https://review.coreboot.org/c/coreboot/+/79951/comment/b506ec55_e6e1ad37 :
PS1, Line 50: // according to FU740 manual:
please use C style comments `/*`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79951?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a0898ce9016a70c0f91dc8a99fc1cf9e46d20c4
Gerrit-Change-Number: 79951
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp.hug@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Attention: Philipp Hug
philipp.hug@gmail.com
Gerrit-Comment-Date: Fri, 19 Jan 2024 05:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment