Attention is currently required from: Martin Roth, Tim Wawrzynczak, Nick Vaccaro, Paul Fagerburg. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57392 )
Change subject: mb/google: Add OEM product names for various boards ......................................................................
Patch Set 5:
(10 comments)
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/57392/comment/66ec3d4f_3c29ac5d PS3, Line 8: Dratini"
(HP Pro c640 Chromebook)
Done
https://review.coreboot.org/c/coreboot/+/57392/comment/2523871c_838607b2 PS3, Line 30: Jinlon"
(HP Elite c1030 Chromebook)
Done
File src/mainboard/google/kahlee/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/57392/comment/3b825bc3_34ebc6cf PS3, Line 4: Kasumi
I was just a bit confused at other places that have Model/Model360 and why not here. […]
Done
https://review.coreboot.org/c/coreboot/+/57392/comment/8ae8673e_909cffee PS3, Line 7: 14A G5
SGTM
Done
File src/mainboard/google/octopus/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/57392/comment/6a353d16_4a0d46b6 PS3, Line 15: 500e
Based on Kasumi/Kasumi360 above, I'd say you could even drop the Phaser360
Done
https://review.coreboot.org/c/coreboot/+/57392/comment/c6f476a4_388a7f7c PS3, Line 28: Fleex"
(Dell Chromebook 3100)
Done
https://review.coreboot.org/c/coreboot/+/57392/comment/7043b9b1_620e61d1 PS3, Line 49: ASUS-Chromebook-Flip-C214
remove hyphens for consistency?
Done
https://review.coreboot.org/c/coreboot/+/57392/comment/4d8cd6f7_fb4da73f PS3, Line 55: Chromebook+
Chromebook 4+
Done
https://review.coreboot.org/c/coreboot/+/57392/comment/aba16700_829db6d1 PS3, Line 61: Bloog"
(HP Chromebook x360 12b)
Done
File src/mainboard/google/poppy/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/57392/comment/b0f4b439_0b794f0a PS3, Line 14: Nami
there's actually a good number of NAMI-based devices: […]
Done