Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42348 )
Change subject: Revert "arch|cpu/x86: Add Kconfig option for x86 reset vector"
......................................................................
Patch Set 1:
Patch Set 1:
CP bootblock/soc/amd/picasso/memlayout.ld
i386-elf-ld.bfd: _start16bit too low. Please report.
So it picks >cpu/x86/16bit/reset16.ld>. While correct, it means means the somewhat ugly X86_RESET_VECTOR, which as a literal constant for 20 odd years, now would need to be defined outside picasso too.
Can you drop <cpu/x86/entry16.ld> and <cpu/x86/reset16.ld> from the mentionded file instead?
Sure, I can take a look.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6b2cc2b17133b3207758c72a54abe80fc6356b5
Gerrit-Change-Number: 42348
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 16:39:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment