Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Subrata Banik, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55270 )
Change subject: soc/intel/alderlake: Add definition for virtual GPIOs
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/alderlake/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123922):
https://review.coreboot.org/c/coreboot/+/55270/comment/d90f2d29_f391b612
PS6, Line 53: INTEL_GPP(GPP_S0, GPP_CPU_RSVD_1,GPP_CPU_RSVD_24), /* GPP_CPU_RSVD */
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d48553d14465df50e5aaaf27ab26c6a1b70d4cf
Gerrit-Change-Number: 55270
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 05:04:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment