Attention is currently required from: Sean Rhodes.
Yidi Lin has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84716?usp=email )
Change subject: soc/intel/*: Add debug prints for misaligned FSP and driver settings
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/84716/comment/80950dbe_7b3a26b2?usp... :
PS9, Line 936: usb_cfg->cnvi_bt_audio_offload = 0;
Hi,
There is a potential error if `usb_cfg` is not assigned in the while loop.
```
src/soc/intel/cannonlake/fsp_params.c:569:48: error: 'usb_cfg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84716?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I449c43998dd379dc68a33db47a2fe51cfe5cda2f
Gerrit-Change-Number: 84716
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik (OOO till 10/18)
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Tue, 15 Oct 2024 14:04:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No