Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32278 )
Change subject: mb/google/hatch: Skip UART0 config in FSP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32278/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32278/1//COMMIT_MSG@11
PS1, Line 11:
Does this decrease the boot time?
I don't think there is going to be any boot time benefit. Currently, we are seeing an issue where UART console stops working if FSP tries to re-initialize it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc88f4fa11bff2144417d5194776c15f9f7b60ac
Gerrit-Change-Number: 32278
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 11 Apr 2019 22:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment