9 Jul
2024
9 Jul
'24
12:43 a.m.
Attention is currently required from: Fabian Groffen, Felix Held, Keith Hui, Keith Hui.
Martin L Roth has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75145?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/asus/p8z77-m: Drop GPIO by I/O ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Added a second LPC generic decode and this GPIO by I/O actually works - I can toggle DRAM_LED right […]
Keith, Sorry, I'm confused by the last comment. What did we want to do with this patch? Should it get merged or not?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75145?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I22654f3c77082bf163ab7000ec467ab7085a0534
Gerrit-Change-Number: 75145
Gerrit-PatchSet: 4
Gerrit-Owner: Fabian Groffen grobian@gentoo.org
Gerrit-Reviewer: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Fabian Groffen grobian@gentoo.org
Gerrit-Comment-Date: Mon, 08 Jul 2024 22:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui buurin@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de