build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45686 )
Change subject: [WIP]mb/prodrive/hermes: Improve board config EEPROM handling ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45686/2/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45686/2/src/mainboard/prodrive/herm... PS2, Line 140: read_write_config(I2C_ADDR_EEPROM, &value, offsetof(struct eeprom_layout, BoardSettings) + line over 96 characters
https://review.coreboot.org/c/coreboot/+/45686/2/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h:
https://review.coreboot.org/c/coreboot/+/45686/2/src/mainboard/prodrive/herm... PS2, Line 30: _Static_assert(sizeof(struct eeprom_layout) == 0x2000, "EEPROM layout size missmatch"); 'missmatch' may be misspelled - perhaps 'mismatch'?