Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )
Change subject: mb/google/volteer/variants/volteer: Add gpio-keys ACPI node for PENH ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... PS3, Line 33: PAD_CFG_GPI_GPIO_DRIVER
I've usually used _GPI_APIC for this before, but I guess the kernel must know how to handle this? Do […]
well, verified interrupts are incrementing via /proc/interrupts
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... PS3, Line 75: wake
this was renamed to `wake_gpe`
thanks. residue of working on older repo...
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... PS3, Line 76: register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
Also since this signal is dual-routed, you'll want to set `register "key. […]
Ack
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... PS3, Line 71: chip drivers/generic/gpio_keys : register "name" = ""PENH"" : # GPP_B3 is the IRQ source, and GPP_E1 is the wake source : register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B3)" : register "key.wake" = "GPE0_DW2_01" : register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" : register "key.dev_name" = ""EJCT"" : register "key.linux_code" = "SW_PEN_INSERTED" : register "key.linux_input_type" = "EV_SW" : register "key.label" = ""pen_eject"" : device generic 0 on end : end
also tabs please 😄
Ack