Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36091 )
Change subject: mb/intel/tigerlake_rvp: Do initial mainboard commit ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... File src/mainboard/intel/tigerlake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... PS8, Line 22: doesn't compile with chromeos disabled
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... File src/mainboard/intel/tigerlake_rvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... PS8, Line 38: start_addr = current; useless function
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... PS8, Line 46: dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; guard with if(CONFIG(CHROMEOS))
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... File src/mainboard/intel/tigerlake_rvp/variants/tgl_up4/memory.c:
https://review.coreboot.org/c/coreboot/+/36091/8/src/mainboard/intel/tigerla... PS8, Line 65: no need for newline