Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35869 )
Change subject: dp_info: read eDP 1.4+ DPCD link rates ......................................................................
Patch Set 3: Verified+1 Code-Review+2
(3 comments)
Thanks!
https://review.coreboot.org/c/libgfxinit/+/35869/1/common/hw-gfx-dp_info.adb File common/hw-gfx-dp_info.adb:
https://review.coreboot.org/c/libgfxinit/+/35869/1/common/hw-gfx-dp_info.adb... PS1, Line 102: Success : out Boolean)
Thinking about this again. I would just make it a local variable. […]
Done
https://review.coreboot.org/c/libgfxinit/+/35869/2/common/hw-gfx-dp_info.adb File common/hw-gfx-dp_info.adb:
https://review.coreboot.org/c/libgfxinit/+/35869/2/common/hw-gfx-dp_info.adb... PS2, Line 93: return Word16
We should add a precondition here for `Offset`. As we read 2 bytes, we'll […]
Done
https://review.coreboot.org/c/libgfxinit/+/35869/2/common/hw-gfx-dp_info.adb... PS2, Line 158: end;
You were correct that loops are a little special. GNATprove doesn't track […]
Done