Hello Marco Chen, Jett Rink, Keith Short, Justin TerAvest, Shelley Chen, build bot (Jenkins), Scott Collyer, Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36068
to look at the new patch set (#4).
Change subject: automation: update script and template files for new variant ......................................................................
automation: update script and template files for new variant
create_coreboot_config.h: * Add a version number for the script and an "auto-generated by" line in the git commit message. * Change the branch name so that it's not the same as the ones that the other scripts will create, so that repo upload on those CLs won't affect this one.
Makefile.inc: * Coreboot build expects to have at least 1 SPD file defined. The author needs to specify the SPDs that are specific to this board, but that can come later. We need to define something so that we can do an initial build and ensure that the new variant has been cloned correctly. * We also need to include our own version of gpio.c in the build.
gpio.h: * The code expects GPIO_MEM_CONFIG_0 through _3 to be defined.
gpio.c: * Need to define tables for GPIO initialization, even if they start out empty.
BUG=b:140261109 BRANCH=None TEST=Create and build the "sushi" variant: $ util/mainboard/google/hatch/create_coreboot_variant.sh sushi $ util/abuild/abuild -p none -t google/hatch -x -a
Prior to this CL, you would get an error message that SPD_SOURCES is not set. If you fixed that, then you would get failures for GPIO_MEM_CONFIG_0, _1, _2, and _3 not defined, and/or gpio_table[] and early_gpio_table[] not defined. After the CL, the build proceeds.
Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1 Signed-off-by: Paul Fagerburg pfagerburg@chromium.org --- M util/mainboard/google/hatch/create_coreboot_variant.sh M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/hatch/template/gpio.c M util/mainboard/google/hatch/template/include/variant/gpio.h 4 files changed, 62 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/36068/4