Attention is currently required from: Sean Rhodes, Nico Huber, Martin Roth, Arthur Heymans, Andrey Petrov, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61872 )
Change subject: soc/apollolake: Create components required for IFWI stitching ......................................................................
Patch Set 16:
(2 comments)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61872/comment/4135ab4f_8ee221b3 PS14, Line 1311: # IFWI Stitching
Can this SOC specific code be moved out of the main makefile. […]
Done
https://review.coreboot.org/c/coreboot/+/61872/comment/04a589e7_3f1dec41 PS14, Line 1321: $(objcbfs)/ibbm.rom: : # Size is calculate as: : # IBBP-Sub-Partition - IBBL - Manifest - BPM.met - Padding : python -c "import struct; fp = open ('$@', 'wb'); \ : fp.write (b'\xFF' * \ : $(shell echo $$((32768 - \ : $(shell stat -Lc %s $(objcbfs)/ibbl.rom) \ : - 748 - 180 - 3168)))); fp.close();" : printf "\nBuilt $@ (0x%x)\n" `stat -c "%s" $@`
Does this need a dependency? Also inline python inside makefiles is a bad idea. […]
I did not know dd could do that, magic!