21 Apr
2023
21 Apr
'23
12:54 p.m.
Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Matt DeVillier, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Arthur Heymans, Fred Reitberger, Tim Chu, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74601 )
Change subject: ACPI: Make FADT entries for RTC/CMOS architectural ......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174712): https://review.coreboot.org/c/coreboot/+/74601/comment/c81a22a5_d5573e8c PS1, Line 32: #define RTC_CENTURY 0x48 please, no space before tabs
--
To view, visit https://review.coreboot.org/c/coreboot/+/74601
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I965a83dc8daaa02ad0935bdde5ca50110adb014a
Gerrit-Change-Number: 74601
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jonathan Zhang jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Tim Chu Tim.Chu@quantatw.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Apr 2023 10:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment