Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42675 )
Change subject: util/mb/google/tmpl/puff: Import overridetree.cb copy ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
That seems like a really large overridetree.cb.
My CR+2 assumes that there isn't a clean way to have most of that in puff and then have the variants just override little bits from puff instead of hatch. Similar to how ec.h now includes puff/ec.h instead of baseboard/ec.h.
That is correct. Unfortunately devicetree overrides do not support multi-layer inheritance were, in our case we have `hatch > puff > variant` and so we actually are overriding hatch directly in the case of dt and so `hatch > variant (copy from puff dt)`. Long term it would be nice to add this multi-layer support to dt however that is the current limitation and is a small price to pay to allow us to allow a sister stream puff to hatch to share the same mainboard/ directory. As with all theses thing, somewhere along the way a compromise needs to be taken and this ended up being ours.