Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42513 )
Change subject: tigerlake: enable tcc_offset functionality
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42513/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42513/3/src/mainboard/google/voltee...
PS3, Line 208: 10
How much testing has this change had? Given the thermal issues we've seen with TGL, will this not make those worse if we allow it to get even hotter before reducing power?
https://review.coreboot.org/c/coreboot/+/42513/3/src/mainboard/google/voltee...
PS3, Line 208: 90C
90 degrees C. This adds 10 degrees C to the default TCC setting of 80 deg C. […]
Thanks Tim, now it makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36b0d6aad4be8a9cbb145dcd66d65235d3f6ac35
Gerrit-Change-Number: 42513
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 19:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment