Attention is currently required from: Dinesh Gehlot, Lance Zhao, Subrata Banik, Tarun Tuli.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70502?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
isn't this a good feature ? we are discussing something with Intel where we proposed to use DSDT injection logic rather SSDT. Typically any SoC fixed configuration like PCI devices alway stayed inside DSDT .
DSDT is for static code that can be generated based on ASL. SSDT is for runtime genrated code. There should never be a reason why something generated at runtime needs to enter DSDT directly. You can refer to it with External.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70502?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1e100cf650b3654240dbf19e1ee3069980fbe93
Gerrit-Change-Number: 70502
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Thu, 22 Jun 2023 13:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment