Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31370 )
Change subject: [WIP] console: Split loglevel for fast and slow
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31370/1/src/console/printk.c
File src/console/printk.c:
https://review.coreboot.org/#/c/31370/1/src/console/printk.c@34
PS1, Line 34: console_tx_byte(byte);
Oh... right, I misread console_write_line(). […]
We should, however, apply AXI_X86 attribute to do_putchar() and collect these together with copies of send_to_console() in one common place.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff56a0a3182f258200cac80e013957d598cc2130
Gerrit-Change-Number: 31370
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 14 Feb 2019 20:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment