Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Poornima Tom, V Sowmya.
Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83138?usp=email )
Change subject: mb/google/brya/var/nivviks: Add wake config for CNVi
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83138/comment/1a444dda_800000f1?usp... :
PS3, Line 14: Verified Wifi 6 detection
this is not a valid test for this code change.
ideally you should be able to dump _DSD for cnvi w/ and w/o this patch to understand what new has been added.
Please capture the changes as well in the commit msg.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83138?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If04539fe8dceb5c2edfc06a324ede11147b78b6d
Gerrit-Change-Number: 83138
Gerrit-PatchSet: 3
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 20 Jun 2024 06:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes