Attention is currently required from: Arthur Heymans, Elyes Haouas, Julius Werner, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81964?usp=email )
Change subject: util/cbfstool: Add `PL64` segment for payload
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS1:
Why not parse the ELF for architecture? […]
Acknowledged
File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:
https://review.coreboot.org/c/coreboot/+/81964/comment/7735cc00_2570275d :
PS2, Line 144: /* 1 for 64-bit payload. 0 for 32-bit payload. */
: uint32_t payload_64_bit;
payload_64_bit is used as boot in util/cbfstool/cbfstool.c file. […]
Acknowledged
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/81964/comment/3646e57d_bddbe3c1 :
PS2, Line 2006: 64
has an x86_64 entry point
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81964?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41562041d6c09869c7966ea31503f002ca1caefa
Gerrit-Change-Number: 81964
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 19 Apr 2024 22:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment