insomniac has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42903 )
Change subject: mb/ocp/deltalake: Use VPD data to configure FSP UPD at romstage
......................................................................
Patch Set 4:
(1 comment)
Just one comment on the VPD variable name, otherwise looks good to me
https://review.coreboot.org/c/coreboot/+/42903/4/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/vpd.h:
https://review.coreboot.org/c/coreboot/+/42903/4/src/mainboard/ocp/deltalake...
PS4, Line 15: #define FSP_LOG "fsp_log" /* 1 or 0: enable or disable FSP SOL log */
I think this could be more explicit, e.g. "fsp_log_enable" or "enable_fsp_log"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b3463acedd90e8e17f7e4eedc2fab63644f87e1
Gerrit-Change-Number: 42903
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: insomniac
insomniac@slackware.it
Gerrit-Comment-Date: Wed, 08 Jul 2020 10:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment